Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration Contract FV #832

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Migration Contract FV #832

merged 8 commits into from
Sep 16, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Sep 16, 2024

Based on #829

Some extra changes:

  • Adding FV to Certora Workflow
  • Remove the unused data from the SafeMock.
  • EOF and some capitalization changes
  • Parametric argument to some rules

@remedcu remedcu self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@coveralls
Copy link

coveralls commented Sep 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10882025386

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.571%
Totals Coverage Status
Change from base Build 10826162794: 0.0%
Covered Lines: 396
Relevant Lines: 408
💛 - Coveralls

@nlordell
Copy link
Collaborator

I rebased this PR and fixed the author to be @hristo-grigorov. The CLA bot should be happy now.

nlordell
nlordell approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this PR (it doesn't have CLA issues).

@remedcu remedcu marked this pull request as ready for review September 16, 2024 10:32
@remedcu remedcu merged commit fddfd14 into main Sep 16, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
@mmv08 mmv08 deleted the migration-fv branch September 16, 2024 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

Assignees

@remedcu remedcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remedcu @coveralls @nlordell @hristo-grigorov