Add zkSync Support To v1.4.1 #767
Assignees
Comments
mmv08
added a commit
that referenced
this issue
Sep 19, 2024
This PR: - Partially solves #767 (test updates for `SafeToL2Upgrade` are still pending) - It is based on version 1.5.0 because 1.4.1 cannot be compiled at the moment because we used `.send` in there, and hardhat zksync compiler plugin needs to be updated to support suppressing errors. I will cherry-pick it later. - I updated the `deployContract` function name and return type to be more self-explanatory - The main changes were around adding zksync compatible bytecode and also using the ContractFactory from the "zksync-ethers" package because in ZkSync you need to interact with a system contract to deploy contracts and not just send a transaction with the bytecode and `to` address omitted. One bug found: matter-labs/hardhat-zksync#1420
mmv08
added a commit
that referenced
this issue
Sep 26, 2024
This PR: - Partially solves #767 (test updates for `SafeToL2Upgrade` are still pending) - It is based on version 1.5.0 because 1.4.1 cannot be compiled at the moment because we used `.send` in there, and hardhat zksync compiler plugin needs to be updated to support suppressing errors. I will cherry-pick it later. - I updated the `deployContract` function name and return type to be more self-explanatory - The main changes were around adding zksync compatible bytecode and also using the ContractFactory from the "zksync-ethers" package because in ZkSync you need to interact with a system contract to deploy contracts and not just send a transaction with the bytecode and `to` address omitted. One bug found: matter-labs/hardhat-zksync#1420
migramirez2
added a commit
to migramirez2/Safe-smart-account
that referenced
this issue
Nov 5, 2024
This PR: - Partially solves safe-global/safe-smart-account#767 (test updates for `SafeToL2Upgrade` are still pending) - It is based on version 1.5.0 because 1.4.1 cannot be compiled at the moment because we used `.send` in there, and hardhat zksync compiler plugin needs to be updated to support suppressing errors. I will cherry-pick it later. - I updated the `deployContract` function name and return type to be more self-explanatory - The main changes were around adding zksync compatible bytecode and also using the ContractFactory from the "zksync-ethers" package because in ZkSync you need to interact with a system contract to deploy contracts and not just send a transaction with the bytecode and `to` address omitted. One bug found: matter-labs/hardhat-zksync#1420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context / issue
Currently, the deployment scripts for Safe contracts do not work on zkSync networks.
Proposed solution
Add support for deploying to Safe contracts to zkSync networks. Note that this identical to #766 but targetted to the v1.4.1 branch so that we can deploy that version of Safe contracts to zkSync networks.
In addition to the expected outcome of the aforementioned issue:
v1.4.1-1release with zkSync deployment supportedAlternatives
Manually deploy the contracts. The downside of this is we explicitly want to support Hyperstack based chains, and manually deploying to each of these chains does not scale well.
The text was updated successfully, but these errors were encountered: