Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for 57073 #832

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add entry for 57073 #832

merged 2 commits into from
Dec 11, 2024

Conversation

rmeissner
Copy link
Member

No need for a transaction, as the factory was pre-deployed

image

@rmeissner rmeissner requested a review from a team as a code owner December 11, 2024 09:54
@akshay-ap akshay-ap self-requested a review December 11, 2024 10:09
Copy link
Member

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see: #821 (comment)

For pre-deployed contracts this is the expected format:

https://github.com/safe-global/safe-singleton-factory?tab=readme-ov-file#op-stack

artifacts/57073/deployment.json Outdated Show resolved Hide resolved
artifacts/57073/deployment.json Outdated Show resolved Hide resolved
@nlordell
Copy link
Collaborator

nlordell commented Dec 11, 2024

Can't really verify without an RPC endpoint (and there isn't one on Chainlist).

Edit: Found the RPC URL on Slack.

@nlordell nlordell merged commit cb13223 into main Dec 11, 2024
@nlordell nlordell deleted the add_57073 branch December 11, 2024 11:07
@akshay-ap
Copy link
Member

Can't really verify without an RPC endpoint (and there isn't one on Chainlist).

Edit: Found the RPC URL on Slack.

I already verified with these commands:

curl -s -X POST $RPC -H 'content-type: application/json' --data '{"jsonrpc":"2.0","id":0,"method":"eth_getCode","params":["0x914d7Fec6aaC8cd542e72Bca78B30650d45643d7","latest"]}' | jq -r .result
0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe03601600081602082378035828234f58015156039578182fd5b8082525050506014600cf3
curl -s -X POST $RPC -H 'content-type: application/json' --data '{"jsonrpc":"2.0","id":0,"method":"eth_getTransactionCount","params":["0xE1CB04A0fA36DdD16a06ea828007E35e1a3cBC37","latest"]}' | jq -r .result
0x0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants