fix(wallet-connect): Removed workaround of accepting all accounts, methods & events in V2 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into chore/update-wallet-connect-packages
DaniSomoza
approved these changes
Jun 21, 2023
|
Looking good! I have tested it following this doc with test data that was shared by the wc team and the results are the expected ones taking into account our implementation. As we know, some connections won't work because of the new restrictions we added for the supported methods but that is the expected and secure behaviour to protect users on a smart contract wallet context. Lets see how it evolves in the near future (I expect some reports from teams and users) but hopefully the wc team will have a better solution for our context soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #705
How this PR fixes it
How to test it
Use https://react-app.walletconnect.com or any other WC v2 DApp
Links
Changes in web3wallet monorepo since 1.2.0