Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use packageManager field #469

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Don't use packageManager field #469

merged 2 commits into from
Jul 19, 2024

Conversation

nlordell
Copy link
Collaborator

This PR removes the use of the pacakgeManager field for a couple of reasons:

  • corepack stuff is experimental (source)
  • It only supports exact versions - so updating our package manager locally can lead to

Instead, I changed to use the engines field that will produce warnings on incompatible versions.

I also removed the safe-contracts exception by solving the lints. It also means we have an ultra-consistent Safe contracts version that we use across all our modules (which has some nice benefits).

@nlordell nlordell requested a review from a team as a code owner July 18, 2024 13:42
@nlordell nlordell requested review from akshay-ap, mmv08 and remedcu and removed request for a team July 18, 2024 13:43
@nlordell nlordell merged commit 1774e79 into main Jul 19, 2024
2 checks passed
@nlordell nlordell deleted the chore/package-json-changes branch July 19, 2024 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants