Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4337 Benchmark: Alchemy with EntryPoint 0.7.0 #466

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jul 18, 2024

This PR partially #316:

  1. It upgrades Alchemy code to use the v0.7.0 of the entrypoint, including all the alchemy-related packages
  2. I exported all the alchemy-related utils function from src/utils/userOps.ts to alchemy/utils.ts
  3. I also added a special exception for the case where the user operations do not involve account deployment where if the account doesn't have enough stake in the entrypoint from the previous deployment user operation, it will execute a call to depositTo in the entry point and inflate the benchmark numbers. Now, a special case is added with the entrypoint deposit before the user operation submission for all user operations that do not involve a deployment.

@mmv08 mmv08 marked this pull request as ready for review July 18, 2024 12:41
@mmv08 mmv08 requested a review from a team as a code owner July 18, 2024 12:41
@mmv08 mmv08 requested review from nlordell, akshay-ap and remedcu and removed request for a team July 18, 2024 12:41
@mmv08 mmv08 force-pushed the benchmark/alchemy-0.7.0 branch from 32a3a1c to cf9e9c3 Compare July 18, 2024 12:55
@mmv08 mmv08 changed the title 4337 Benchmark: Alchemy with EntryPoint 0.7.0 and no paymaster 4337 Benchmark: Alchemy with EntryPoint 0.7.0 Jul 18, 2024
@mmv08 mmv08 force-pushed the benchmark/alchemy-0.7.0 branch from 34536b6 to 68c0cc1 Compare July 18, 2024 15:32
@coveralls
Copy link

coveralls commented Jul 18, 2024

Pull Request Test Coverage Report for Build 10008017937

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10006957722: 0.0%
Covered Lines: 92
Relevant Lines: 92

💛 - Coveralls

@mmv08 mmv08 force-pushed the benchmark/alchemy-0.7.0 branch from 68c0cc1 to 23a3118 Compare July 19, 2024 12:26
@mmv08 mmv08 merged commit f84200f into main Jul 19, 2024
20 checks passed
@mmv08 mmv08 deleted the benchmark/alchemy-0.7.0 branch July 19, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants