-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature Length Check FV #464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedcu
requested review from
nlordell,
akshay-ap and
mmv08
and removed request for
a team
July 15, 2024 13:47
Pull Request Test Coverage Report for Build 9988150675Details
💛 - Coveralls |
remedcu
force-pushed
the
fv-signature-length-check
branch
from
July 15, 2024 13:54
734f021
to
764de09
Compare
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
akshay-ap
reviewed
Jul 16, 2024
akshay-ap
reviewed
Jul 16, 2024
akshay-ap
reviewed
Jul 16, 2024
akshay-ap
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
reviewed
Jul 16, 2024
nlordell
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #461
This PR adds a rule which verifies that the signature length check is ensured using the
_checkSignaturesLength(...)
in theSafe4337Module
.The rule ensures that a signature that the bundler could manipulate, which could clear the check in Safe using
checkSignatures(...)
will still get caught using the_checkSignaturesLength(...)
. For this, we use acanonicalSignatureHash(...)
which generates the same hash for valid signatures, with and without the excess data. An example is added to show this case before the function is written.Also have added the workflow for checking the same in CI (Currently, it uses a script, which will be modified in a later PR to be consistent with our other repos).