Update Passkey Example for Release #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have released the passkey package, the 4337 example can be updated to use the released packages instead of the development code. I also change the configuration to make use of the `*-deployments` packages to make sure the example works on the "real" addresses. I manually ran the example application and was successful with creating and executing user operations: - [Safe creation userOp](https://sepolia.etherscan.io/tx/0xdcab84d43b4bbd954c13fd991615c2490b0c6e59a058e46764d2875e6dbf4e4f) - [Transfer userOp](https://sepolia.etherscan.io/tx/0x15210fb522c94907bc38bb99cc9b1020a20e32e19c517f8fed04f607c9c1d666)
remedcu
approved these changes
Jun 17, 2024
|
I want to wait for @mmv08's review before merging (as the "main" code owner of this package). |
mmv08
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have released the passkey package, the 4337 example can be updated to use the released packages instead of the development code.
I also change the configuration to make use of the
*-deploymentspackages to make sure the example works on the "real" addresses.I manually ran the example application and was successful with creating and executing user operations: