Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: PNPM Changes In Single Commit [DO NOT MERGE OR REVIEW] #422

Closed
wants to merge 1 commit into from

Conversation

nlordell
Copy link
Collaborator

It looks like GitHub CI "files changed" rules only check the last commit and not all commits. This means we may get false positive CI passes for PRs that have many changes where the last one only runs a small subset of CI.

This PR just just here to test the changes as a single PR, thus ensuring that all relevant CI is executed.

It looks like GitHub CI "files changed" rules only check the *last*
commit and not all commits. This means we may get false positive CI
passes for PRs that have many changes where the last one only runs a
small subset of CI.

This PR just just here to test the changes as a single PR, thus ensuring
that **all** relevant CI is executed.
@nlordell nlordell mentioned this pull request May 16, 2024
@coveralls
Copy link

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9112964207

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9062559032: 0.0%
Covered Lines: 147
Relevant Lines: 147

💛 - Coveralls

@nlordell
Copy link
Collaborator Author

Yay! CI passes.

@nlordell nlordell closed this May 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@nlordell nlordell deleted the test-all-changes-single-commit branch May 16, 2024 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants