Add Gas Benchmarking Tests for WebAuthn Signer #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds gas benchmarking tests for the WebAuthn signer. Note that we got rid of the
MultipleVerifiers.spec.ts
file, as it is essentially the new gas benchmarking tests, and there was no need to duplicate the work.The benchmarks look like this:
Note that we include a "dummy" benchmark, this is because gas consumption of P-256 signature verification is unstable, and this allows us to better compare gas characteristics of the
WebAuthn
signing message computation overhead.Furthermore, we remove the check on whether or not the P-256 verifier has code. This is important as precompiles have no code, so our WebAuthn stuff wouldn't work with precompiles without this change.