Update deploy section in the readme
#189
Conversation
mmv08
commented
Dec 11, 2023
- Fix the dead link for the releases page (follow-up: do tags like 0.1.0 work well for a monorepo?)
- Remove the compiler settings from the section; we have a separate section about compiler settings.
1. Fix the dead link for the releases page (follow-up: do tags like 0.1.0 work well for a monorepo?) 2. Remove the compiler settings from the section; we have a separate section about compiler settings.
Pull Request Test Coverage Report for Build 7164295038
💛 - Coveralls |
| @@ -156,9 +156,9 @@ npm run test:e2e | |||
|
|
|||
| ### Deploy | |||
|
|
|||
| > :warning: **Make sure to use the correct commit when deploying the contracts.** Any change (even comments) within the contract files will result in different addresses. The tagged versions used by the Safe team can be found in the [releases](https://github.com/safe-modules/releases). | |||
| > :warning: **Make sure to use the correct commit when deploying the contracts.** Any change (even comments) within the contract files will result in different addresses. The tagged versions used by the Safe team can be found in the [releases](https://github.com/safe-global/safe-modules/releases). | |||
There was a problem hiding this comment.
Currently our releases are not up to date, something we need to follow up on
There was a problem hiding this comment.
If we plan to have more modules in the monorepo, I would employ the same setup with changelogs and stuff as we did for the safe-apps-sdk using changesets: https://github.com/safe-global/safe-apps-sdk/releases
What I have seen work well for monorepos is So here, I would create a |
Agree, that's how it's done in the safe-apps-sdk repo |