Ambigious behaviour with WebAuthn shim #369
Assignees
Labels
bug
Something isn't working
Comments
|
Uploading the log archive in case GitHub decides to delete the run. |
|
Another failure, this time with the Log Link: https://github.com/safe-global/safe-modules/actions/runs/9990468990/job/27611219692 |
|
I think that is an unrelated issue @remedcu, in fact the WebAuthn shim does not appear to be used in the failing test - it is just taking a little more gas than expected. |
|
I think I found the issue, and it lies in the |
|
what a legend |
nlordell
added a commit
that referenced
this issue
Jul 23, 2024
Fixes #369 This PR bumps the version of `@simplewebauthn/server` to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature `r` or `s` value, which would cause the test to periodically fail (since the signature was random in each run - as both the private kay and the challenge were randomly generated).
nlordell
added a commit
that referenced
this issue
Jul 23, 2024
Fixes #369 This PR bumps the version of `@simplewebauthn/server` to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature `r` or `s` value, which would cause the test to periodically fail (since the signature was random in each run - as both the private kay and the challenge were randomly generated).
nlordell
added a commit
that referenced
this issue
Jul 23, 2024
Fixes #369 This PR bumps the version of `@simplewebauthn/server` to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature `r` or `s` value, which would cause the test to periodically fail (since the signature was random in each run - as both the private kay and the challenge were randomly generated).
nlordell
added a commit
that referenced
this issue
Jul 23, 2024
Fixes #369 This PR bumps the version of `@simplewebauthn/server` to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature `r` or `s` value, which would cause the test to periodically fail (since the signature was random in each run - as both the private kay and the challenge were randomly generated).
nlordell
added a commit
that referenced
this issue
Jul 23, 2024
Fixes #369 This PR bumps the version of `@simplewebauthn/server` to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature `r` or `s` values, which would cause the test to periodically fail (since the signature was random in each run - as both the private key and the challenge were randomly generated, meaning that we would occasionally have an `r` or `s` value with a leading `0` byte).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The test "Should authorise and verify an existing credential" in the
WebAuthn Shimsection fails unexpectedly (Source)Steps to reproduce
This fails rarely, as the next run of the job returns
true.Additional context
The problem was found during changes created in PR #356 (though no change in the concerned file was made).
The text was updated successfully, but these errors were encountered: