Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock event view #56

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Add lock event view #56

merged 3 commits into from
Apr 5, 2024

Conversation

moisses89
Copy link
Member

Close #20

  • Fix a serializer class typo
  • Refactor CommonEvent serializer to add optional EventType.

@moisses89 moisses89 requested a review from a team as a code owner April 4, 2024 08:10
Uxio0
Uxio0 approved these changes Apr 5, 2024
View reviewed changes
safe_locking_service/locking_events/serializers.py Outdated Show resolved Hide resolved
safe_locking_service/locking_events/serializers.py Outdated Show resolved Hide resolved
@moisses89 @Uxio0
Apply suggestions from code review
c2997ca 
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
@moisses89 moisses89 merged commit 9da5df5 into main Apr 5, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
@moisses89 moisses89 deleted the add_lock_event_view branch April 8, 2024 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GET Locked events by holder
2 participants
@moisses89 @Uxio0