Skip to content

Commit

Permalink
Move supported networks .md folder into safe-smart-accounts
Browse files Browse the repository at this point in the history
  • Loading branch information
louis-md committed Nov 22, 2023
1 parent 4952f3a commit d6794cc
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions .github/scripts/generateSupportedNetworks.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@ const deduplicate = () => [
[]
]

const supportedNetworksPath = './safe-smart-account/supported-networks'

const generateSupportedNetworks = async () => {
const deploymentRepoUrl = 'https://github.com/safe-global/safe-deployments/'
shell.exec(`git clone ${deploymentRepoUrl} ./deployments`)
shell.rm('-rf', './supported-networks')
shell.rm('-rf', supportedNetworksPath)

const fetch = await import('node-fetch')
const paths = walkPath('deployments/src/assets').map(p =>
Expand Down Expand Up @@ -64,7 +66,7 @@ const generateSupportedNetworks = async () => {
.reduce(...deduplicate())
.reverse()

shell.mkdir('./supported-networks')
shell.mkdir(supportedNetworksPath)

versions.forEach(version => {
const _contracts = contracts.flat().filter(c => c.version === version)
Expand Down Expand Up @@ -111,7 +113,7 @@ ${_contracts
.join('\n')}
`
fs.writeFileSync(`./supported-networks/${version}.md`, content)
fs.writeFileSync(`${supportedNetworksPath}/${version}.md`, content)
})

shell.rm('-rf', './deployments')
Expand Down
2 changes: 1 addition & 1 deletion safe-smart-account/supported-networks.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
This section lists the addresses of all the Safe contracts deployed grouped by version and chain. The same list can be found on the [GitHub repository](https://github.com/safe-global/safe-deployments), from which these pages are automatically generated.

The most recent version of the Safe contracts is `v1.4.1`, which adds compatibility with the ERC-4337. However, it is not supported yet in the[Safe{Wallet}](app.safe.global) interface and the Safe Transaction Service. For that reason, depending on your use case, it might be recommended to continue using `v1.3.0` until there is better support.
The most recent version of the Safe contracts is `v1.4.1`, which adds compatibility with the ERC-4337. However, it is not supported yet in the [Safe{Wallet}](app.safe.global) interface and the Safe Transaction Service. For that reason, depending on your use case, it might be recommended to continue using `v1.3.0` until there is better support.

Check failure on line 3 in safe-smart-account/supported-networks.md

View workflow job for this annotation

GitHub Actions / vale

[vale] safe-smart-account/supported-networks.md#L3

[Microsoft.Contractions] Use 'it's' instead of 'it is'.
Raw output
{"message": "[Microsoft.Contractions] Use 'it's' instead of 'it is'.", "location": {"path": "safe-smart-account/supported-networks.md", "range": {"start": {"line": 3, "column": 113}}}, "severity": "ERROR"}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit d6794cc

Please sign in to comment.