New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use origin.note for tx notes #2233

Merged

katspaugh merged 1 commit into main from origin-note

Jan 3, 2025

Member

katspaugh commented Jan 3, 2025

Summary

A follow-up on #2223 thanks to @iamacook's diligence:

We'll now use a separate sub-field of the origin field that doesn't interfere with any previous logic in tx-service
origin.note is taken as is and passed to the TransactionDetails.note field for multisig txs


          Fix: use origin.note for tx notes

b33153b

katspaugh requested a review from a team as a code owner

January 3, 2025 10:06

iamacook approved these changes

View reviewed changes

katspaugh merged commit f023b19 into main

20 checks passed

katspaugh deleted the origin-note branch

January 3, 2025 11:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet