Remove timestamp-reference transaction from start of page #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PooyaRaki
reviewed
Dec 16, 2024
|
It looks good to me 👍 ; I just have one remaining question. |
PooyaRaki
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We group transactions by day, in between which we add date labels.
When fetching the first page of transactions (
offeset=0), we group/label the result as is. For subsequent pages (offset>0), we modify the pagination to request the last transaction of the previous page in order to determine whether we return an initial date label or not, before removing it and mapping the remanining transactions.Currently, the removal of this "extra" transaction is not assigning correctly due to abstraction into a separate function. This adjusts the logic flow to ensure the "extra" transaction is removed where it is passed to the mapper.
Changes
sliceinto main mapping function.