Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helper throughout KilnApi #2165

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Use helper throughout KilnApi #2165

merged 1 commit into from
Dec 4, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 2, 2024

Summary

Kiln returns all responses nested in a data property. Within the KilnApi, we have a helper that parses this, casting the response as Raw accordingly. This is, however, not used consistently throughout the service.

This removes all redundant code, using the helper everywhere.

Changes

  • Move all validation/error handling inside helper
  • Use helper in all methods

@iamacook iamacook self-assigned this Dec 2, 2024
@iamacook iamacook requested a review from a team as a code owner December 2, 2024 15:49
@iamacook iamacook merged commit 77f0e72 into main Dec 4, 2024
20 checks passed
@iamacook iamacook deleted the kiln-helper branch December 4, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants