Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timestamp can’t be null #2133

Merged
merged 16 commits into from
Nov 19, 2024
Merged

fix: timestamp can’t be null #2133

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a596b33
fix: swagger output concrete module execution type
compojoom Nov 15, 2024
8ad767c
fix: swagger improve TransactionInfo output
compojoom Nov 15, 2024
51a1e2e
fix: swagger output concrete txStatus in Transaction type
compojoom Nov 15, 2024
6aae302
fix: output the concrete queued item type in swagger
compojoom Nov 15, 2024
ffc24d2
fix: swagger output concrete tx detail execution type
compojoom Nov 15, 2024
146c426
fix: swagger output concrete conflictType
compojoom Nov 15, 2024
ccad422
fix: swagger output concrete transfer type
compojoom Nov 15, 2024
bbf9a02
fix: swagger improve transferInfo output
compojoom Nov 15, 2024
475b2dc
fix: swagger output QueuedItem type
compojoom Nov 15, 2024
a1709e5
fix: swagger output executionInfo type
compojoom Nov 15, 2024
1e9df49
fix: swagger output concrete transfer direction
compojoom Nov 15, 2024
b1dec14
fix: swagger output possible transfer objects for SwapTransferTransac…
compojoom Nov 15, 2024
3d6e0bc
fix: swapper output concrete transaction entity type
compojoom Nov 15, 2024
3ed8837
fix: swagger output concrete DateLabel type
compojoom Nov 15, 2024
c467a01
fix: timestamp can’t be null
compojoom Nov 15, 2024
b2d5440
Merge branch 'main' into timestamp
hectorgomezv Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/routes/transactions/entities/transaction.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export class Transaction {
id: string;
@ApiPropertyOptional({ type: String, nullable: true })
txHash: `0x${string}` | null;
@ApiPropertyOptional({ type: Number, nullable: true })
timestamp: number | null;
@ApiProperty()
timestamp: number;
@ApiProperty({ enum: TransactionStatus })
txStatus: string;
@ApiProperty({
Expand Down Expand Up @@ -72,7 +72,7 @@ export class Transaction {

constructor(
id: string,
timestamp: number | null,
timestamp: number,
txStatus: string,
txInfo: TransactionInfo,
executionInfo: ExecutionInfo | null = null,
Expand Down