Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to v22.11.0 (LTS) #2080

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update Node to v22.11.0 (LTS) #2080

merged 2 commits into from
Nov 7, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 30, 2024

Summary

The latest LTS version of Node has been released (v22.11.0). As such, this makes the relevant changes to use it in the project.

Changes

  • Use 22.11.0 in all actions/setup-node
  • Update our .nvmrc
  • Use "jod" in our Dockerfile
  • Update our README

@iamacook iamacook self-assigned this Oct 30, 2024
@iamacook
Copy link
Member Author

I'm marking this as a draft as the actions/setup-node node-version is having issues with "Jod".

@PooyaRaki
Copy link
Contributor

PooyaRaki commented Oct 30, 2024

Now that we are upgrading the Node version, I suggest we tag the exact version instead of lts

@iamacook
Copy link
Member Author

Now that we are upgrading the Node version, I suggest we tag the exact version instead of lts

Agreed. As this is currently blocked due to the workflow compatibility, I'd suggest pinning the version once unblocked. That way we will have the latest tag pinned.

@iamacook iamacook marked this pull request as ready for review November 6, 2024 16:05
@iamacook iamacook requested a review from a team as a code owner November 6, 2024 16:05
@iamacook
Copy link
Member Author

iamacook commented Nov 6, 2024

@PooyaRaki, I've now pinned the version.

@iamacook iamacook merged commit 40e72aa into main Nov 7, 2024
20 checks passed
@iamacook iamacook deleted the node-lts-jod branch November 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants