Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relaying of recovery proposals/executions #2078

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

iamacook
Copy link
Member

Summary

Resolves #1638

We only allow relaying of Safe interactions and transfers. For recoverers, the process of transacting may be confusing and facilitating the relaying of recovery proposals/executions would simplify this.

This adds support relaying of "valid" recovery proposals/executions:

  • DelayModifier proposal (execTransactionFromModule) or execution (executeNextTx)
  • (Batch) transaction(s) to add/remove/swap owners or change threshold on a Safe
  • Via an enabled module on said Safe

Changes

  • Update encoder/decoder to support proposal/execution methods of DelayModifiers
  • Add support for valid relaying proposals/executions, limiting the address of the Safe being recovered
  • Add relevant test coverage

@iamacook iamacook self-assigned this Oct 29, 2024
@iamacook iamacook requested a review from a team as a code owner October 29, 2024 09:24
@iamacook iamacook merged commit e82eec3 into main Nov 4, 2024
20 checks passed
@iamacook iamacook deleted the relay-recovery branch November 4, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow relaying of recovery transactions
2 participants