Improve "echo" detection #2057
Merged
Improve "echo" detection #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Oct 25, 2024
| return false; | ||
| } | ||
|
|
||
| return this.isImitationAddress(txInfo, prevTxInfo); |
There was a problem hiding this comment.
Whilst this check occurs in both methods, I thought it clearer to include it in both.
hectorgomezv
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An "echo" poisoning attempt is when an attacker sends a small amount of a token back to you after sending some to a receipient. The token address is therefore the same, the value low and the recipient similar in vanity.
This fixes the token address comparison as we were previously comparing a token against itself, and it adds a vanity check.
Changes