Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the Delegate results as array #2047

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Mark the Delegate results as array #2047

merged 1 commit into from
Oct 24, 2024

Conversation

iamacook
Copy link
Member

Summary

All results of a Page in the project are an array of entities. The DelegatePage correctly extends the interface responsible for this but does not mark the results array as one.

This adds the isArray flag to the ApiProperty of the respective Swagger decorator.

Changes

  • Add isArray flag to ApiProperty decorator of DelegatePage['results]

@iamacook iamacook self-assigned this Oct 24, 2024
@iamacook iamacook requested a review from a team as a code owner October 24, 2024 09:18
usame-algan
usame-algan approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hectorgomezv hectorgomezv merged commit 310ff25 into main Oct 24, 2024
20 checks passed
@hectorgomezv hectorgomezv deleted the delegates-swagger branch October 24, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

@usame-algan usame-algan usame-algan approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamacook @usame-algan @hectorgomezv