Fix DB initialization on E2E tests #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
commented
Oct 16, 2024
| @@ -17,8 +15,6 @@ describe('Get about e2e test', () => { | |||
| const moduleRef = await Test.createTestingModule({ | |||
| imports: [AppModule.register()], | |||
| }) | |||
| .overrideModule(PostgresDatabaseModule) | |||
There was a problem hiding this comment.
Not directly related to the fix, but this mock was previously added to prevent this initialization error and it's no longer needed.
iamacook
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the SSL certificate path to the e2e tests. Otherwise, these tests would fail as they don't mock the database. As
PostgresDatabaseModuleis now part of theAppModule, the actual Postgres container needs to be available on the e2e test execution context.Changes
POSTGRES_SSL_ENABLEDandPOSTGRES_SSL_CA_PATHto thee2e-setup.tsconfiguration.