Refactor notification controller error handling

safe-global · Dec 5, 2024 · 6a9aa2f · 6a9aa2f
1 parent ac5074b
commit 6a9aa2f
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/routes/notifications/v1/notifications.controller.ts b/src/routes/notifications/v1/notifications.controller.ts
@@ -202,10 +202,9 @@ export class NotificationsController {
     } catch (error: unknown) {
       // The token might already have been removed from the TX service.
       // If this happens, the TX service will throw a 404 error, but it is safe to ignore it.
-      if (error instanceof Error) {
-        if ('code' in error && error.code !== 404) {
-          throw error;
-        }
+      const errorObject = error as { code?: number };
+      if (errorObject?.code !== 404) {
+        throw error;
       }
     }
   }
@@ -258,10 +257,9 @@ export class NotificationsController {
     } catch (error: unknown) {
       // The token might already have been removed from the TX service.
       // If this happens, the TX service will throw a 404 error, but it is safe to ignore it.
-      if (error instanceof Error) {
-        if ('code' in error && error.code !== 404) {
-          throw error;
-        }
+      const errorObject = error as { code?: number };
+      if (errorObject?.code !== 404) {
+        throw error;
       }
     }
   }