Android set support?

[harrydema]

When it is going to support the set() method for Android?

[safaiyeh]

Looks like Android API supports it: https://developer.android.com/reference/android/webkit/CookieManager.html#setCookie(java.lang.String,%20java.lang.String)

I'll check it out and put up a PR. Would you mind testing it when it is up? @harrydema

[safaiyeh]

React Native has support for adding cookies; however, the method is private: https://github.com/facebook/react-native/blob/aee88b6843cea63d6aa0b5879ad6ef9da4701846/ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java#L127

Will make a PR to core to make the method public and see how that route goes.

[harrydema]

Let me know when it is available, and i will test it.

This is the PR on core:
facebook/react-native#27512

Take a look a test failed

[harrydema]

Can't we use this publlic method instead? @safaiyeh

[safaiyeh]

Yeah that test is a known issue. It fails on every PR.

We currently use that with setFromResponse: https://github.com/safaiyeh/react-native-cookie-store/blob/master/android/src/main/java/com/psykar/cookiemanager/CookieManagerModule.java#L40

My issue is that I have to transform the data in a weird way for it to work. I can use it as a temporary implementation.

[harrydema]

I am trying to implement it, the thing is that when i set 3 cookies on a same url, they get replaced, even if they have different names.

This is what i have so far:

I am setting the domain as the url, IDK if this is ok. What do you think?

[safaiyeh]

So cookie will be in this format:

{
  name: 'myCookie',
  value: 'myValue',
  domain: 'some domain',
  origin: 'some origin',
  path: '/',
  version: '1',
  expiration: '2015-05-30T12:30:00.00-05:00'
}

My initial thought was to create a string builder and make these fields required.

Thanks for taking the initiative to seek out an implementation!

[harrydema]

I am not being able to set several cookies for the same url, when ever a set a new cookie on a url, the past values are removed. Would you please help me to figure out this?

[safaiyeh]

I’ll take a look today 😁

[harrydema]

I will send a PR

[harrydema]

I am setting 3 cookies:

2019-12-16 16:10:04.528 7313-7367/com.test.local I/headers: {Set-Cookie=[path=/, origin=.test.com, domain=.test.com, name=CloudFront-Key-Pair-Id, expiration=2099-05-30T12:30:00.00-05:00, version=1, value=XXXX]}
2019-12-16 16:10:04.534 7313-7367/com.test.local I/headers: {Set-Cookie=[path=/, origin=.test.com, domain=.test.com, name=CloudFront-Policy, expiration=2099-05-30T12:30:00.00-05:00, version=1, value=XXXX]}
2019-12-16 16:10:04.541 7313-7367/com.test.local I/headers: {Set-Cookie=[path=/, origin=.test.com, domain=.test.com, name=CloudFront-Signature, expiration=2099-05-30T12:30:00.00-05:00, version=1, value=XXXX]}

But when I do a get, and print all the cookies:

I get only the last cookie:

2019-12-16 16:10:01.531 7313-7367/com.test.local I/cookieMap: {Cookie=[path=/; origin=.test.com; domain=.test.com; name=CloudFront-Signature; expiration=2099-05-30T12:30:00.00-05:00; version=1; value=XXXX]}

[harrydema]

I noticed this is for webkit only. It won't work for requests. Could it be?

[safaiyeh]

Yeah that is what https://github.com/safaiyeh/react-native-cookie-store/blob/master/android/src/main/java/com/psykar/cookiemanager/CookieManagerModule.java#L40 is using.

[harrydema]

How can I test if this is woking? If I do a fetch('https://google.com') I can't see the cookies being sent

[harrydema]

After researching a lot, I found out there is a bigger problem behind this:

facebook/react-native#23185

[safaiyeh]

If it is an issue with the react native repo, we can migrate out of using their functions and just use CookieManager. I'll have more time today to look into it. Sorry, still at work haha.

[safaiyeh]

@harrydema I might have figured out a solution, I pushed it to your PR.

[KingAmo]

could you please explain to me that what is the difference between set and setFromResponse ? i am a lit confused, the README showcase seems they are the same...

[safaiyeh]

The PR I made to React Native, just got merged in today. I'll try out using their API

[safaiyeh]

@KingAmo they are the same in the sense that they both store cookies.

The data format the method accepts is different. setFromResponse takes Set-Cookie response headers. While set should take a JSON object of attributes.

[safaiyeh]

on pause until change to react native gets released, will work to get cherry picked.