Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#61 Update Text Spacing to 1.6px in login/signup/password reset/password set page #62

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

aniketkaushik
Copy link
Contributor

@aniketkaushik aniketkaushik commented Jan 7, 2022

Fixes #61

What is the issue : Letter spacing of 0.8px
How we can solve the issue : change letter spacing to 1.6px
What are cause of issue : font

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-62 January 7, 2022 07:35 Inactive
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Current Code Coverage Percent of this PR:

93.68 %

Files having coverage below 100%

Impacted Files Coverage
/config/routes.rb 85.71 %
/app/controllers/application_controller.rb 42.86 %
/app/controllers/users/registrations_controller.rb 80.0 %

@aniketkaushik aniketkaushik changed the title Fixes#61 letter spacing to 1.6px Fixes#61 Update Text Spacing to 1.6px in login/signup/password reset/password set page Jan 7, 2022
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-62 January 7, 2022 08:51 Inactive
Copy link

@AkashKale AkashKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@akhilgkrishnan akhilgkrishnan merged commit 7990542 into develop Jan 7, 2022
@akhilgkrishnan akhilgkrishnan deleted the letter-spacing-fix branch January 7, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Update Text Spacing to 1.6px in login/signup/password reset/password set page
4 participants