Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restricted employee on client details page #348

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

Shruti-Apte
Copy link
Contributor

Notion card

https://www.notion.so/saeloun/Don-t-redirect-employees-to-client-details-page-1f653f71f6b94c09bfca3c54ce35b0e6

Summary

Restricted employees on client details page

Preview

https://www.loom.com/share/a9964dd4285c4dbaaffe9aaeb47b637e

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@github-actions
Copy link

Current Code Coverage Percent of this PR:

96.51 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.31 %
/app/models/invoice.rb 95.83 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/services/application_service.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 43.48 %

@apoorv1316 apoorv1316 merged commit 433ca02 into develop Apr 28, 2022
@apoorv1316 apoorv1316 deleted the Bug/restrict_employee_on_client_details_page branch April 28, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants