Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code revereted for invoice and time tracking #310

Merged
merged 1 commit into from
Apr 22, 2022
Merged

code revereted for invoice and time tracking #310

merged 1 commit into from
Apr 22, 2022

Conversation

ajinkyaa
Copy link
Contributor

  • hide the delete button and multiline functionality.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

vipulnsward
vipulnsward approved these changes Apr 22, 2022
View reviewed changes
app/javascript/src/components/time-tracking/WeeklyEntries.tsx
Logger.error(error.message);
}
};
// const handleDeleteEntries = async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete code, we avoid commenting

@apoorv1316 apoorv1316 self-requested a review April 22, 2022 05:00
@apoorv1316 apoorv1316 merged commit 03ffeb4 into develop Apr 22, 2022
@apoorv1316 apoorv1316 deleted the client-time-track-code-reverted branch April 22, 2022 05:00
@vipulnsward
Copy link
Contributor

So confused why merged? Anyways Ajinkya please fix the last changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@vipulnsward vipulnsward vipulnsward approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajinkyaa @vipulnsward @apoorv1316