Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Dashboard #306

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Hide Dashboard #306

merged 3 commits into from
Apr 21, 2022

Conversation

aniketkaushik
Copy link
Contributor

@aniketkaushik aniketkaushik commented Apr 21, 2022

Hiding Dashboard for now, as it is blank

https://www.loom.com/share/0b35c2e68de042809e55d29412d9c606

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented Apr 21, 2022

Current Code Coverage Percent of this PR:

100.0 %

@apoorv1316
Copy link
Contributor

@aniket-k-kaushik Why do we have so much commented code?

@aniketkaushik
Copy link
Contributor Author

@aniket-k-kaushik Why do we have so much commented code?

This solutions is temporary, as we have dashboard blank for now. We want to redirect all uses to time-tracking and in future we will again make dashboard default for admin and owner and then we would need that commented code and we will remove this PR code

@apoorv1316 apoorv1316 self-requested a review April 21, 2022 11:34
Copy link
Contributor

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from functional perspective

@supriya3105 supriya3105 merged commit c8a3f46 into develop Apr 21, 2022
@supriya3105 supriya3105 deleted the hide-dashboard branch April 21, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants