Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE]Restructure error json #305

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[BE]Restructure error json #305

merged 1 commit into from
Apr 21, 2022

Conversation

apoorv-mishra
Copy link
Contributor

Notion card

NA

Summary

This PR changes to error structure and message in response to be handled by FE

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

Current Code Coverage Percent of this PR:

99.75 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/concerns/error_handler.rb 97.73 %
/app/controllers/projects_controller.rb 85.71 %

@apoorv1316
Copy link
Collaborator

@aniket-k-kaushik @shivamsinghchahar @akhilgkrishnan Please review it. We need to merge this ASAP

shivamsinghchahar
shivamsinghchahar approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@shivamsinghchahar shivamsinghchahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aniketkaushik
aniketkaushik approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@aniketkaushik aniketkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Rebase it with latest develop

@apoorv-mishra apoorv-mishra merged commit 9ffc3b8 into develop Apr 21, 2022
@apoorv-mishra apoorv-mishra deleted the handle-save-invoice-errors branch April 21, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkaushik aniketkaushik aniketkaushik approved these changes

@shivamsinghchahar shivamsinghchahar shivamsinghchahar approved these changes

@rohitjoshixyz rohitjoshixyz Awaiting requested review from rohitjoshixyz

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apoorv-mishra @apoorv1316 @shivamsinghchahar @aniketkaushik