Add sidekiq #291
Merged
Add sidekiq #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Code Coverage Percent of this PR:98.17 %Files having coverage below 100%
|
shivamsinghchahar
suggested changes
Apr 19, 2022
There was a problem hiding this comment.
@rohitjoshixyz Suggested some changes 👇
Also, Can't find the Procfile for production, we'd want to add worker command to that as well.
Comment on lines
+5
to
+6
| :queues: | ||
| - default |
There was a problem hiding this comment.
Suggested change
| :queues: | |
| - default | |
| queues: | |
| - default | |
| - mailers | |
| - action_mailbox_routing | |
| - action_mailbox_incineration | |
| - active_storage_analysis | |
| - active_storage_purge |
There was a problem hiding this comment.
I found this https://mikerogers.io/2019/06/06/rails-6-sidekiq-queues Are you suggesting adding them for the same reason? Are they used internally by active storage automatically or do we need more configuration? @shivamsinghchahar
There was a problem hiding this comment.
Yes, exactly 💯
That's all we need, no additional configuration.
|
@rohitjoshixyz Another thing is sidekiq web UI, could we add that as well. |
akhilgkrishnan
approved these changes
Apr 20, 2022
Add Procfile for production Add more queues for active storage Remove sidekiq for test env
shivamsinghchahar
suggested changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/Add-sidekiq-for-background-job-processing-0f2e618cda454d6980db0826cf202f8d
Summary
Followed: https://www.bigbinary.com/learn-rubyonrails-book/background-job-processing-using-sidekiq
Verified queuing is working by creating a job that puts "Sidekiq job executed" into the console.
Updated the readme to mention installing Redis.
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: