Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client details page #282

Merged
merged 13 commits into from
Apr 19, 2022
Merged

Client details page #282

merged 13 commits into from
Apr 19, 2022

Conversation

ajinkyaa
Copy link
Contributor

Client Details page

Type of change

  • Client Details page.
  • react routes added to the client
  • new client modal added.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

focus:outline-none
text-miru-han-purple-1000">
<option className="text-miru-dark-purple-600" value="week">
THIS WEEK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space indent

<div className="rounded-lg px-6 pb-6 bg-white shadow-xl transform transition-all sm:align-middle sm:max-w-md modal-width">
<div className="flex justify-between items-center mt-6">
<h6 className="text-base font-extrabold">Add New Client</h6>
<button type="button" onClick={() => { setnewClient(false); }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to write in one-line

<button type="button" onClick={() => setnewClient(false) }>

@supriya3105
Copy link
Contributor

@ajinkyaa The CI test suite if failing the branch is not deployed.

@github-actions
Copy link

Current Code Coverage Percent of this PR:

98.17 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/clients_controller.rb 38.89 %
/app/controllers/concerns/error_handler.rb 97.73 %
/app/models/project.rb 90.32 %

@vipulnsward vipulnsward merged commit 7aa86c8 into develop Apr 19, 2022
@vipulnsward vipulnsward deleted the client-details-page branch April 19, 2022 00:47
@vipulnsward
Copy link
Contributor

@ajinkyaa please send changes in new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants