UI/project list page updations

[Shruti-Apte]

Notion card

https://www.notion.so/saeloun/Remaining-work-on-Project-list-page-refactoring-22ad94893d14411d8e565160c38a40c8

Summary

API integration for project list page

Preview

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

• I have performed a self-review of my own code

[github-actions]

Current Code Coverage Percent of this PR:

97.79 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/clients_controller.rb	94.44 %
/app/models/project.rb	90.32 %
/app/controllers/users/omniauth_callbacks_controller.rb	25.0 %
/app/controllers/internal_api/v1/timesheet_entry/bulk_action_controller.rb	50.0 %

[ajinkyaa]

why write a function for this?
Also code should be
await projectApi.get() .then(res => {// set state}) .catch(e => {//error handling}

[shivamsinghchahar]

@ajinkyaa Why use .then and .catch with await?

We should not be using .then and .catch with async/await. It defeats the whole purpose of having async/await in the first place.

We should write it like this:

const fetchClients = async () => {
  try {
    const data = await projectApi.get();
    // state updates
  } catch {
    // handle errors
  }
}

cc// @Shruti-Apte

[ajinkyaa]

why reload the window?

[vipulnsward]

Please send another PR

[Shruti-Apte]

Please send another PR

Okay! with loom video you mean?