Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password controller test coverage #269

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Conversation

gowsik-ragunath
Copy link
Contributor

Notion card

Summary

Added test cases for devise password controller

Current test coverage: 92.32%

Preview

Screenshot 2022-04-15 at 11 17 21 AM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-269 April 15, 2022 05:53 Inactive
@github-actions
Copy link

Current Code Coverage Percent of this PR:

96.4 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/clients_controller.rb 94.44 %
/app/models/project.rb 90.32 %
/app/controllers/users/registrations_controller.rb 40.0 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/internal_api/v1/timesheet_entry/bulk_action_controller.rb 50.0 %

Copy link
Contributor

@alkesh26 alkesh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's not commit .DS_Store along with your changes.

Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vipulnsward vipulnsward merged commit 43e9fe5 into develop Apr 15, 2022
@alkesh26 alkesh26 deleted the password-test-coverage branch April 15, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants