-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give client and project index page access to employee #268
Give client and project index page access to employee #268
Conversation
Current Code Coverage Percent of this PR:91.03 %Files having coverage below 100%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from functional perspective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammatical errors in spec description and discuss with Gowsik for the failing spec and uncomment it before the merge.
I would suggest using Grammarly and performing a self-review before assigning for a review to avoid such nitpicks
# Check why following test is failing with Gowsik and uncomment following | ||
# expect(response).to have_http_status(:redirect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address this before merging else we tend to never fix it on priority
Co-authored-by: Rohit Joshi <rohit.joshiadvanced@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! After you fix Rohit's suggestions and merge conflicts.
@@ -42,12 +42,34 @@ | |||
context "when the user is an employee" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top level should describe blocks
Notion card
Summary
Added client and project list page access for employees. It was giving forbidden error.
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: