-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Line Items Entries API for Generate Invoice #250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketkaushik
force-pushed
the
line-iteams-api
branch
from
April 12, 2022 17:31
2fc7930
to
4121543
Compare
aniketkaushik
force-pushed
the
line-iteams-api
branch
from
April 13, 2022 11:26
4121543
to
62b7d9e
Compare
Current Code Coverage Percent of this PR:91.03 %Files having coverage below 100%
|
aniketkaushik
requested review from
rohitjoshixyz,
keshavbiswa,
akhilgkrishnan,
alkesh26 and
apoorv-mishra
April 13, 2022 11:31
aniketkaushik
changed the title
Line iteams api
New Line Items Entries API for Generate Invoice
Apr 13, 2022
akhilgkrishnan
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aditya-vector
approved these changes
Apr 14, 2022
keshavbiswa
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
apoorv-mishra
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion card
https://saeloun.notion.site/Fetch-the-entries-from-time-tracking-for-generate-invoice-Back-end-972e95bc0abf454385bb510cdb6e0769
API
http://127.0.0.1:3000/internal_api/v1/generate_invoice/1?page=2&selected_entries[]=1&selected_entries[]=2
items per page is 10 (means 10 line item entries will be fetched on a single API call)
selected_entries (entries which are already selected and we want to skip them in the next api call)
Type of change
Please delete options that are not relevant.
Checklist: