Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Interaction gem #248

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add Interaction gem #248

merged 1 commit into from
Apr 12, 2022

Conversation

rohitjoshixyz
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz commented Apr 12, 2022 •
edited
Loading

Notion card

https://saeloun.notion.site/Add-interaction-gem-f6560ceb48ee49548f535cc926392de9

Summary

Add interaction gem to the project. Alkesh will follow up with converting timesheet entry logic into an interaction class

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-248 April 12, 2022 08:50 Inactive
akhilgkrishnan
akhilgkrishnan approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitjoshixyz rohitjoshixyz merged commit 1b8c564 into develop Apr 12, 2022
@rohitjoshixyz rohitjoshixyz deleted the add-interaction-gem branch April 12, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

@keshavbiswa keshavbiswa Awaiting requested review from keshavbiswa

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohitjoshixyz @akhilgkrishnan @vipulnsward @alkesh26