Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Client phone number and company name in generate invoice api #238

Conversation

aniketkaushik
Copy link
Contributor

@aniketkaushik aniketkaushik commented Apr 6, 2022

Notion card

Added Client phone number and company name in generate invoice api

{
  "company_details": {
    "id": 1,
    "logo": "https://miru-review-pr-238.herokuapp.com/rails/active_storage/blobs/redirect/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBCZz09IiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--32b9d38b4332cf83cf60be9f0d47554627cb9ca7/saeloun_logo.png",
    "name": "Saeloun India Pvt. Ltd",
    "phone_number": "+91 0000000000",
    "address": "somewhere in India",
    "country": "IN"
  },
  "issue_date": "2022-04-06",
  "due_date": "2022-05-06",
  "company_client_list": [
    {
      "id": 1,
      "name": "client_1_saeloun_India",
      "email": "client_one@saeloun_india.com",
      "phone": "+91 9999999991",
      "address": "Somewhere on Earth"
    },
    {
      "id": 2,
      "name": "client_2_saeloun_India",
      "email": "client_two@saeloun_india.com",
      "phone": "+91 9999999992",
      "address": "Somewhere on Earth"
    }
  ]
}

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@aniketkaushik aniketkaushik requested a review from ajinkyaa April 6, 2022 09:59
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-238 April 6, 2022 09:59 Inactive
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Current Code Coverage Percent of this PR:

83.54 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/invoices_controller.rb 66.67 %
/app/controllers/concerns/error_handler.rb 73.81 %
/app/controllers/concerns/timesheet.rb 75.0 %
/app/controllers/projects_controller.rb 46.15 %
/app/controllers/clients_controller.rb 94.44 %
/app/controllers/workspaces_controller.rb 77.78 %
/app/models/company.rb 91.3 %
/app/models/project.rb 89.66 %
/app/models/timesheet_entry.rb 76.92 %
/app/policies/invoice_policy.rb 80.0 %
/app/policies/project_policy.rb 85.71 %
/app/policies/timesheet_entry_policy.rb 50.0 %
/app/policies/client_policy.rb 80.0 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/registrations_controller.rb 40.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/policies/timesheet_entry/bulk_action_policy.rb 50.0 %
/app/controllers/internal_api/v1/reports_controller.rb 88.89 %
/app/controllers/internal_api/v1/projects_controller.rb 71.43 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 40.0 %
/app/controllers/internal_api/v1/clients_controller.rb 80.77 %
/app/controllers/internal_api/v1/workspaces_controller.rb 85.71 %
/app/controllers/internal_api/v1/timesheet_entry/bulk_action_controller.rb 50.0 %

@aniketkaushik aniketkaushik changed the title Client phone number and company name in generate invoice api Added Client phone number and company name in generate invoice api Apr 6, 2022
Comment on lines 62 to 64
clients.kept.map { |client|
{ id: client.id, name: client.name, email: client.email, phone: client.phone, address: client.address }
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the statement inside the do..end block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-238 April 6, 2022 11:32 Inactive
@aniketkaushik aniketkaushik merged commit e23008a into develop Apr 6, 2022
@ajinkyaa ajinkyaa deleted the client_phone_number_and_company_name_in_generate_invoice_api branch April 6, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants