-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Client phone number and company name in generate invoice api #238
Merged
aniketkaushik
merged 3 commits into
develop
from
client_phone_number_and_company_name_in_generate_invoice_api
Apr 6, 2022
Merged
Added Client phone number and company name in generate invoice api #238
aniketkaushik
merged 3 commits into
develop
from
client_phone_number_and_company_name_in_generate_invoice_api
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Code Coverage Percent of this PR:83.54 %Files having coverage below 100%
|
aniketkaushik
changed the title
Client phone number and company name in generate invoice api
Added Client phone number and company name in generate invoice api
Apr 6, 2022
rohitjoshixyz
approved these changes
Apr 6, 2022
app/models/company.rb
Outdated
Comment on lines
62
to
64
clients.kept.map { |client| | ||
{ id: client.id, name: client.name, email: client.email, phone: client.phone, address: client.address } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the statement inside the do..end block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
ajinkyaa
deleted the
client_phone_number_and_company_name_in_generate_invoice_api
branch
April 6, 2022 11:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion card
Added Client phone number and company name in generate invoice api
Checklist: