Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project details design #226

Merged
merged 25 commits into from
Apr 4, 2022
Merged

Project details design #226

merged 25 commits into from
Apr 4, 2022

Conversation

ajinkyaa
Copy link
Contributor

@ajinkyaa ajinkyaa commented Mar 29, 2022

Type of change

Please delete options that are not relevant.

  • Project details design
  • table common component
  • bannerbox common component
  • header menubar updated

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 March 29, 2022 08:32 Inactive
@ajinkyaa ajinkyaa marked this pull request as draft March 30, 2022 04:05
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 March 30, 2022 05:32 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 March 30, 2022 05:49 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 March 30, 2022 15:00 Inactive
@ajinkyaa ajinkyaa marked this pull request as ready for review April 4, 2022 10:48
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 April 4, 2022 12:43 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 April 4, 2022 12:46 Inactive
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Current Code Coverage Percent of this PR:

78.12 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/invoices_controller.rb 66.67 %
/app/controllers/concerns/error_handler.rb 73.81 %
/app/controllers/concerns/timesheet.rb 75.0 %
/app/controllers/projects_controller.rb 46.15 %
/app/controllers/clients_controller.rb 94.44 %
/app/controllers/workspaces_controller.rb 77.78 %
/app/models/company.rb 90.91 %
/app/models/project.rb 89.66 %
/app/models/timesheet_entry.rb 76.92 %
/app/policies/project_policy.rb 85.71 %
/app/policies/timesheet_entry_policy.rb 50.0 %
/app/policies/client_policy.rb 80.0 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/registrations_controller.rb 40.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/policies/timesheet_entry/bulk_action_policy.rb 50.0 %
/app/controllers/internal_api/v1/reports_controller.rb 88.89 %
/app/controllers/internal_api/v1/projects_controller.rb 71.43 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 40.0 %
/app/controllers/internal_api/v1/clients_controller.rb 80.77 %
/app/controllers/internal_api/v1/workspaces_controller.rb 85.71 %
/app/controllers/internal_api/v1/timesheet_entry/bulk_action_controller.rb 50.0 %
/lib/authentication/google.rb 0.0 %

Copy link
Contributor

@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 April 4, 2022 13:31 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 April 4, 2022 13:57 Inactive
@AkashKale
Copy link

image

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 April 4, 2022 15:30 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-226 April 4, 2022 15:49 Inactive
@ajinkyaa ajinkyaa merged commit 3fca9f3 into develop Apr 4, 2022
@pr-triage pr-triage bot removed the PR: unreviewed label Apr 4, 2022
@ajinkyaa ajinkyaa deleted the project-details-design branch April 4, 2022 15:56
@pr-triage pr-triage bot added the PR: merged label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants