Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bullet gem and updated readme with seed info #223

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Added bullet gem and updated readme with seed info #223

merged 1 commit into from
Mar 28, 2022

Conversation

alkesh26
Copy link
Contributor

Notion card

https://saeloun.notion.site/Fix-N-1-query-f7836df2aff240ed8e1b51683c95d920

Summary

  1. Adding the bullet gem.

Preview

Screenshot 2022-03-28 at 3 30 06 PM

Screenshot 2022-03-28 at 5 57 53 PM

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Running the App on local

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-223 March 28, 2022 13:40 Inactive
@alkesh26 alkesh26 requested a review from rohitjoshixyz March 28, 2022 13:41
@alkesh26 alkesh26 self-assigned this Mar 28, 2022
keshavbiswa
keshavbiswa approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

akhilgkrishnan
akhilgkrishnan approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rohitjoshixyz
rohitjoshixyz approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alkesh26 alkesh26 merged commit 05db500 into fix-n-plus-one Mar 28, 2022
@alkesh26 alkesh26 deleted the added-bullet-gem-and-updated-readme branch March 28, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshavbiswa keshavbiswa keshavbiswa approved these changes

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees

@alkesh26 alkesh26

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alkesh26 @akhilgkrishnan @rohitjoshixyz @keshavbiswa @vipulnsward