APIs for invoice list page #208

apoorv-mishra · 2022-03-16T15:55:07Z

Notion card

https://saeloun.notion.site/API-s-for-Invoice-98d674e7750046b8971590753b8a938a

Summary

Includes API for fetching invoices

Preview

NA

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

github-actions · 2022-03-16T15:56:15Z

Current Code Coverage Percent of this PR:

78.98 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/concerns/error_handler.rb	73.81 %
/app/controllers/projects_controller.rb	46.15 %
/app/controllers/concerns/timesheet.rb	75.0 %
/app/controllers/invoices_controller.rb	66.67 %
/app/controllers/workspaces_controller.rb	77.78 %
/app/controllers/clients_controller.rb	94.44 %
/app/models/company.rb	90.91 %
/app/models/timesheet_entry.rb	76.92 %
/app/models/project.rb	89.66 %
/app/policies/timesheet_entry_policy.rb	50.0 %
/app/policies/project_policy.rb	85.71 %
/app/policies/client_policy.rb	80.0 %
/app/controllers/users/passwords_controller.rb	41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb	25.0 %
/app/controllers/users/sessions_controller.rb	25.0 %
/app/controllers/users/registrations_controller.rb	40.0 %
/app/controllers/internal_api/v1/projects_controller.rb	75.0 %
/app/controllers/internal_api/v1/reports_controller.rb	88.89 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb	40.0 %
/app/controllers/internal_api/v1/workspaces_controller.rb	85.71 %
/app/controllers/internal_api/v1/clients_controller.rb	80.77 %
/lib/authentication/google.rb	0.0 %

supriya3105 · 2022-03-23T13:35:23Z

@shivamsinghchahar can you review this PR

keshavbiswa

Few suggestions, rest looks good.

app/controllers/internal_api/v1/invoices_controller.rb

app/models/company.rb

app/models/invoice.rb

config/initializers/pagy.rb

app/controllers/internal_api/v1/invoices_controller.rb

spec/models/invoice_spec.rb

app/controllers/internal_api/v1/invoices_controller.rb

shivamsinghchahar

@apoorv-mishra Please look at the comments below

app/controllers/internal_api/v1/invoices_controller.rb

app/models/invoice.rb

config/initializers/pagy.rb

spec/models/invoice_spec.rb

spec/requests/internal_api/v1/invoices/index_spec.rb

shivamsinghchahar

@apoorv-mishra Please look at the comments below

app/controllers/internal_api/v1/invoices_controller.rb

spec/requests/internal_api/v1/invoices/index_spec.rb

app/views/internal_api/v1/invoices/index.json.jbuilder

shivamsinghchahar

LGTM 🚀

keshavbiswa

LGTM!

app/models/invoice.rb

app/controllers/concerns/error_handler.rb

spec/rails_helper.rb

spec/requests/internal_api/v1/invoices/index_spec.rb

akhilgkrishnan

LGTM

rohitjoshixyz

LGTM

keshavbiswa · 2022-03-28T13:56:10Z

spec/models/invoice_spec.rb

@@ -41,7 +41,7 @@

  describe "Associations" do
    describe "belongs to" do
-      it { is_expected.to belong_to(:company) }
+      it { is_expected.not_to belong_to(:company) }


I think we can just remove this spec? There is no point of checking for absent belongs_to associations.

On second thought, why isn't there a company association to an invoice or am I missing something?

keshavbiswa · 2022-03-28T13:58:02Z

spec/models/invoice_spec.rb

+    end
+  end
+
+  describe ".delegate" do


Suggested change

describe ".delegate" do

describe "Delegates" do

Apoorv Mishra added 2 commits March 16, 2022 21:14

Adds API for fetching invoices

c254e42

Merge branch 'develop' into invoice-api

68b5542

apoorv-mishra changed the title ~~Invoice api~~ [WIP]API for fetching invoices Mar 16, 2022

pr-triage bot added the PR: draft label Mar 16, 2022

vipulnsward temporarily deployed to miru-review-pr-208 March 16, 2022 16:24 Inactive

Return resp json as per the contract

c850cd4

vipulnsward temporarily deployed to miru-review-pr-208 March 17, 2022 07:03 Inactive

Apoorv Mishra added 3 commits March 22, 2022 17:09

Integrate pagy for handling pagination

6556e27

Incorporate invoice filters

980e2b9

Add specs for scopes

d7696cd

vipulnsward temporarily deployed to miru-review-pr-208 March 23, 2022 05:15 Inactive

Apoorv Mishra added 2 commits March 23, 2022 12:37

Add invoice summary API

7959624

Add request specs for invoice list and invoices summary APIs

d9821f7

vipulnsward temporarily deployed to miru-review-pr-208 March 23, 2022 13:11 Inactive

apoorv-mishra marked this pull request as ready for review March 23, 2022 13:33

pr-triage bot removed the PR: draft label Mar 23, 2022

apoorv-mishra requested review from keshavbiswa, akhilgkrishnan and rohitjoshixyz March 23, 2022 13:34

apoorv-mishra changed the title ~~[WIP]API for fetching invoices~~ APIs for invoice list page Mar 23, 2022

pr-triage bot added the PR: unreviewed label Mar 23, 2022

apoorv-mishra requested a review from shivamsinghchahar March 23, 2022 13:37

keshavbiswa requested changes Mar 23, 2022

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Mar 23, 2022

akhilgkrishnan reviewed Mar 24, 2022

View reviewed changes

app/controllers/internal_api/v1/invoices_controller.rb Outdated Show resolved Hide resolved

shivamsinghchahar suggested changes Mar 24, 2022

View reviewed changes

app/controllers/internal_api/v1/invoices_controller.rb Outdated Show resolved Hide resolved

app/controllers/internal_api/v1/invoices_controller.rb Outdated Show resolved Hide resolved

app/controllers/internal_api/v1/invoices_controller.rb Outdated Show resolved Hide resolved

rohitjoshixyz reviewed Mar 24, 2022

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels Mar 25, 2022

shivamsinghchahar suggested changes Mar 25, 2022

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: partially-approved labels Mar 25, 2022

Address minor code style issues

0d92365

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels Mar 25, 2022

vipulnsward temporarily deployed to miru-review-pr-208 March 25, 2022 14:52 Inactive

apoorv-mishra requested a review from shivamsinghchahar March 25, 2022 14:56

shivamsinghchahar approved these changes Mar 25, 2022

View reviewed changes

keshavbiswa approved these changes Mar 25, 2022

View reviewed changes

app/models/invoice.rb Show resolved Hide resolved

app/controllers/concerns/error_handler.rb Show resolved Hide resolved

spec/rails_helper.rb Outdated Show resolved Hide resolved

spec/requests/internal_api/v1/invoices/index_spec.rb Show resolved Hide resolved

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Mar 25, 2022

akhilgkrishnan approved these changes Mar 28, 2022

View reviewed changes

rohitjoshixyz approved these changes Mar 28, 2022

View reviewed changes

Merge branch 'develop' into invoice-api

e01d1f1

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Mar 28, 2022

vipulnsward temporarily deployed to miru-review-pr-208 March 28, 2022 13:41 Inactive

Fix spec

5e822a6

vipulnsward temporarily deployed to miru-review-pr-208 March 28, 2022 13:49 Inactive

apoorv-mishra merged commit 885d7c0 into develop Mar 28, 2022

pr-triage bot added PR: merged and removed PR: unreviewed labels Mar 28, 2022

keshavbiswa reviewed Mar 28, 2022

View reviewed changes

pr-triage bot added PR: unreviewed and removed PR: merged labels Mar 28, 2022

keshavbiswa reviewed Mar 28, 2022

View reviewed changes

akhilgkrishnan deleted the invoice-api branch April 5, 2022 04:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

APIs for invoice list page #208

APIs for invoice list page #208

apoorv-mishra commented Mar 16, 2022 •

edited

Loading

github-actions bot commented Mar 16, 2022 •

edited

Loading

supriya3105 commented Mar 23, 2022

keshavbiswa left a comment

shivamsinghchahar left a comment

shivamsinghchahar left a comment

shivamsinghchahar left a comment

keshavbiswa left a comment

akhilgkrishnan left a comment

rohitjoshixyz left a comment

keshavbiswa Mar 28, 2022

keshavbiswa Mar 28, 2022

keshavbiswa Mar 28, 2022

APIs for invoice list page #208

APIs for invoice list page #208

Conversation

apoorv-mishra commented Mar 16, 2022 • edited Loading

Notion card

Summary

Preview

Type of change

How Has This Been Tested?

Checklist:

github-actions bot commented Mar 16, 2022 • edited Loading

Current Code Coverage Percent of this PR:

78.98 %

Files having coverage below 100%

supriya3105 commented Mar 23, 2022

keshavbiswa left a comment

Choose a reason for hiding this comment

shivamsinghchahar left a comment

Choose a reason for hiding this comment

shivamsinghchahar left a comment

Choose a reason for hiding this comment

shivamsinghchahar left a comment

Choose a reason for hiding this comment

keshavbiswa left a comment

Choose a reason for hiding this comment

akhilgkrishnan left a comment

Choose a reason for hiding this comment

rohitjoshixyz left a comment

Choose a reason for hiding this comment

keshavbiswa Mar 28, 2022

Choose a reason for hiding this comment

keshavbiswa Mar 28, 2022

Choose a reason for hiding this comment

keshavbiswa Mar 28, 2022

Choose a reason for hiding this comment

apoorv-mishra commented Mar 16, 2022 •

edited

Loading

github-actions bot commented Mar 16, 2022 •

edited

Loading