-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap note text on reports page #203
Conversation
Current Code Coverage Percent of this PR:78.3 %Files having coverage below 100%
|
@shalapatil got this on testing it Credentials used for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now, should we consider truncating the note if it's very long, say more than 2000 characters, at least for the index page? cc @keshavbiswa @akhilgkrishnan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@shalapatil Updated the screenshot of the test I ran for this fix. I can still see that the text is not wrapped. |
Yes I think truncating long texts would be a good idea. |
Can you try mobile view too, @shalapatil |
@shalapatil Please resolve the conflicts on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
4662d69
to
7cc0c73
Compare
@supriya3105 This are the latest screenshots, working fine |
I will work on truncate in separate commit |
Notion card
Summary
https://www.notion.so/saeloun/Text-wrapping-is-required-on-notes-field-on-time-entry-report-5d312940b2644b879dd076d7496b8fd2
Fixed the wrapping of note on reports page
Preview
Before
after
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: