-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress & Github actions integration #197
Conversation
Current Code Coverage Percent of this PR:71.09 %Files having coverage below 100%
|
runTests: false | ||
- name: Cypress tests | ||
run: | | ||
npm run cy:run:staging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only run the test on the staging server. we have to run the test on review apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each PR there will be seperate app. Is there any way we can handle the dynamic url in cypress testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't seen it earlier. Looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akhilgkrishnan regression suit is supposed to be run after the prs are merged. Staging is the right place to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 .
Note: We need to run the cypress test for each pr review apps before merging to the develop
Apoorv is working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add on ci for each pr.
No description provided.