Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress & Github actions integration #197

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

apoorv1316
Copy link
Contributor

No description provided.

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-197 March 11, 2022 05:57 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-197 March 11, 2022 06:02 Inactive
@github-actions
Copy link

Current Code Coverage Percent of this PR:

71.09 %

Files having coverage below 100%

Impacted Files Coverage
/app/helpers/application_helper.rb 89.47 %
/app/helpers/team_helper.rb 85.71 %
/app/controllers/concerns/error_handler.rb 73.53 %
/app/controllers/projects_controller.rb 42.86 %
/app/controllers/time_tracking_controller.rb 36.36 %
/app/controllers/concerns/timesheet.rb 37.5 %
/app/controllers/root_controller.rb 42.86 %
/app/controllers/workspaces_controller.rb 77.78 %
/app/controllers/clients_controller.rb 94.44 %
/app/models/timesheet_entry.rb 73.08 %
/app/models/project.rb 90.91 %
/app/policies/timesheet_entry_policy.rb 50.0 %
/app/policies/client_policy.rb 75.0 %
/app/controllers/companies/purge_logo_controller.rb 50.0 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 42.11 %
/app/controllers/users/invitations_controller.rb 64.29 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 42.86 %
/app/controllers/internal_api/v1/workspaces_controller.rb 85.71 %
/app/controllers/internal_api/v1/clients_controller.rb 66.67 %
/lib/authentication/google.rb 0.0 %

runTests: false
- name: Cypress tests
run: |
npm run cy:run:staging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only run the test on the staging server. we have to run the test on review apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each PR there will be seperate app. Is there any way we can handle the dynamic url in cypress testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen it earlier. Looking into it.

Copy link
Contributor

@mohinid mohinid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhilgkrishnan regression suit is supposed to be run after the prs are merged. Staging is the right place to do so.

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 .

Note: We need to run the cypress test for each pr review apps before merging to the develop

@mohinid
Copy link
Contributor

mohinid commented Mar 14, 2022

Apoorv is working on it.

Copy link
Contributor

@mohinid mohinid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add on ci for each pr.

@mohinid mohinid merged commit fd250c7 into develop Mar 14, 2022
@akhilgkrishnan akhilgkrishnan deleted the cypress-github-actions-integration branch March 15, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants