Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template for preview, notion card and comment unnecessary text #178

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

rohitjoshixyz
Copy link
Contributor

Pull Request Template

Description

Update the PR template to include preview, section to add notion card and comment unnecessary text
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-178 March 3, 2022 08:13 Inactive
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Current Code Coverage Percent of this PR:

71.96 %

Files having coverage below 100%

Impacted Files Coverage
/app/helpers/application_helper.rb 89.47 %
/app/helpers/team_helper.rb 85.71 %
/app/controllers/concerns/error_handler.rb 73.53 %
/app/controllers/projects_controller.rb 42.86 %
/app/controllers/time_tracking_controller.rb 36.36 %
/app/controllers/concerns/timesheet.rb 37.5 %
/app/controllers/root_controller.rb 42.86 %
/app/controllers/workspaces_controller.rb 77.78 %
/app/controllers/clients_controller.rb 94.44 %
/app/models/timesheet_entry.rb 88.89 %
/app/models/project.rb 90.91 %
/app/policies/client_policy.rb 75.0 %
/app/controllers/companies/purge_logo_controller.rb 50.0 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 42.11 %
/app/controllers/users/invitations_controller.rb 64.29 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 35.71 %
/app/controllers/internal_api/v1/workspaces_controller.rb 85.71 %
/app/controllers/internal_api/v1/clients_controller.rb 66.67 %
/lib/authentication/google.rb 0.0 %

@rohitjoshixyz rohitjoshixyz merged commit 13715dc into develop Mar 3, 2022
@akhilgkrishnan akhilgkrishnan deleted the update-pr-template branch March 8, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants