create invitation presenter #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasanthchaduvula
requested changes
Mar 28, 2024
| lastName: invitation.last_name, | ||
| email: invitation.recipient_email, | ||
| role: invitation.role, | ||
| status: "INVITATION PENDING", |
There was a problem hiding this comment.
Instead of status value sending from the backend, let frontend use the whatever message they want to display. Its better to send the key accepted_at
There was a problem hiding this comment.
Shruti asked me to send the same keys that are use in GET requests for teams. LMK if we have to change
There was a problem hiding this comment.
For status, we have to use accepted_at . On the frontend, they can display any message as the messages keep on changing.
fcefdd0 to
cd6149a
Compare
prasanthchaduvula
requested changes
Apr 8, 2024
app/presenters/team_presenter.rb
Outdated
|
|
||
| I18n.t("team.invitation") | ||
| def invited_user_status(member) | ||
| user_employed_at_current_company && member.accepted_at |
There was a problem hiding this comment.
Use accepted_at? return boolean
| json.last_name invitation.last_name | ||
| json.email invitation.recipient_email | ||
| json.role invitation.role | ||
| json.status invitation.accepted_at |
There was a problem hiding this comment.
Use accepted_at? returns boolean
added 2 commits
April 8, 2024 14:11
a7d8f3e to
958a4f9
Compare
prasanthchaduvula
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why