Fixed address field on organisation edit page #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge with develop
|
Please add loom with edge cases and get it confirmed from Sonam |
|
Would you like to have this in address line 2 as well @apoorv1316, @sonamvg, @supriya3105? |
|
@Shruti-Apte @nisusam Yes. The same changes should be applicable on the address line 2 field as well. Also @Shruti-Apte Can you share the validations that have been added to all the address related fields ? |
added 2 commits
March 4, 2024 21:54
|
@supriya3105 Validations for address fields: Address line 1:
Address line 2:
|
supriya3105
approved these changes
Mar 5, 2024
nisusam
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #1678
loom: https://www.loom.com/share/3c6a0d26935142d891d352c777213d72?sid=c2ac9507-ca43-4efe-a6e6-0466ce4e3c47