Enable Time-off entry in "Day" view #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d21904 to
15f889b
Compare
supriya3105
approved these changes
Feb 14, 2024
|
@JijoBose Please merge only after the code reviews are done. |
apoorv1316
approved these changes
Feb 15, 2024
nisusam
reviewed
Feb 15, 2024
| key={index} | ||
| className={ | ||
| item === view | ||
| ? "mr-10 border-b-2 border-miru-han-purple-1000 font-bold tracking-widest text-miru-han-purple-1000" |
There was a problem hiding this comment.
a small suggestion to keep the shared classes outside ternary like mr-10 tracking-widest
There was a problem hiding this comment.
Thanks, I've made the changes
nisusam
approved these changes
Feb 15, 2024
15f889b to
1af51b2
Compare
1af51b2 to
4e7ee89
Compare
|
@JijoBose Please merge if the work is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion:
https://www.notion.so/Enable-Timeoff-for-Day-view-470bc12917a34a74b186b0a070fd0aaf
What
Why
Screenshots:
Screen-recording:
Brave.Browser.-.Miru._.Time.tracking.and.invoicing.-.13.February.2024.mp4