-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent (-)ve values for standard price of company #162
Conversation
6ce578a
to
e85cdb2
Compare
e85cdb2
to
a08c20b
Compare
Current Code Coverage Percent of this PR:58.04 %Files having coverage below 100%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after adding spec as @apoorv-mishra suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 . Thanks @mayank0109 for working on this
@mayank0109 Can you please work on the feedback and close this PR. |
c7b8b93
to
5514d0c
Compare
Pull Request Template
Description
Fixes #129
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: