Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent (-)ve values for standard price of company #162

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

mayank0109
Copy link
Contributor

@mayank0109 mayank0109 commented Feb 18, 2022

Pull Request Template

Description

Fixes #129

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-162 February 18, 2022 14:09 Inactive
@mayank0109 mayank0109 force-pushed the 129-prevent-negative-standard-value branch from 6ce578a to e85cdb2 Compare February 18, 2022 14:11
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-162 February 18, 2022 14:11 Inactive
@mayank0109 mayank0109 force-pushed the 129-prevent-negative-standard-value branch from e85cdb2 to a08c20b Compare February 18, 2022 14:24
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-162 February 18, 2022 14:25 Inactive
@github-actions
Copy link

Current Code Coverage Percent of this PR:

58.04 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/companies_controller.rb 92.86 %
/app/helpers/application_helper.rb 93.33 %
/app/helpers/team_helper.rb 57.14 %
/app/controllers/projects_controller.rb 50.0 %
/app/controllers/time_tracking_controller.rb 30.0 %
/app/controllers/concerns/timesheet.rb 37.5 %
/app/controllers/root_controller.rb 33.33 %
/app/controllers/team_controller.rb 38.46 %
/app/controllers/dashboard_controller.rb 66.67 %
/app/controllers/clients_controller.rb 37.5 %
/app/controllers/concerns/error_handler.rb 60.0 %
/app/models/timesheet_entry.rb 88.24 %
/app/models/project.rb 90.91 %
/app/controllers/companies/purge_logo_controller.rb 50.0 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 45.83 %
/app/controllers/users/invitations_controller.rb 63.64 %
/app/controllers/internal_api/v1/application_controller.rb 85.71 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 35.71 %
/lib/authentication/google.rb 0.0 %

app/models/company.rb Show resolved Hide resolved
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding spec as @apoorv-mishra suggested

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 . Thanks @mayank0109 for working on this

@akhilgkrishnan akhilgkrishnan temporarily deployed to miru-review-pr-162 February 25, 2022 12:38 Inactive
@supriya3105
Copy link
Contributor

@mayank0109 Can you please work on the feedback and close this PR.

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-162 March 8, 2022 05:56 Inactive
@mayank0109 mayank0109 force-pushed the 129-prevent-negative-standard-value branch from c7b8b93 to 5514d0c Compare March 8, 2022 06:03
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-162 March 8, 2022 06:03 Inactive
@mayank0109 mayank0109 requested review from apoorv-mishra and removed request for apoorv-mishra March 8, 2022 06:28
@mayank0109 mayank0109 merged commit c905d99 into develop Mar 8, 2022
@akhilgkrishnan akhilgkrishnan deleted the 129-prevent-negative-standard-value branch March 8, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup org page- Standard price going in negative.
6 participants