Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refator day timetracking #158

Merged
merged 27 commits into from
Mar 8, 2022
Merged

Refator day timetracking #158

merged 27 commits into from
Mar 8, 2022

Conversation

abinashpa
Copy link
Contributor

@abinashpa abinashpa commented Feb 17, 2022

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@abinashpa abinashpa self-assigned this Feb 17, 2022
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 February 17, 2022 12:11 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 February 17, 2022 12:17 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 February 17, 2022 12:24 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 February 17, 2022 12:34 Inactive
@github-actions
Copy link

github-actions bot commented Feb 17, 2022

Current Code Coverage Percent of this PR:

71.04 %

Files having coverage below 100%

Impacted Files Coverage
/app/helpers/application_helper.rb 89.47 %
/app/helpers/team_helper.rb 85.71 %
/app/controllers/concerns/error_handler.rb 73.53 %
/app/controllers/projects_controller.rb 42.86 %
/app/controllers/time_tracking_controller.rb 36.36 %
/app/controllers/concerns/timesheet.rb 37.5 %
/app/controllers/root_controller.rb 42.86 %
/app/controllers/workspaces_controller.rb 77.78 %
/app/controllers/clients_controller.rb 94.44 %
/app/models/timesheet_entry.rb 73.08 %
/app/models/project.rb 90.91 %
/app/policies/timesheet_entry_policy.rb 50.0 %
/app/policies/client_policy.rb 75.0 %
/app/controllers/companies/purge_logo_controller.rb 50.0 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 42.11 %
/app/controllers/users/invitations_controller.rb 64.29 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 42.86 %
/app/controllers/internal_api/v1/workspaces_controller.rb 85.71 %
/app/controllers/internal_api/v1/clients_controller.rb 66.67 %
/lib/authentication/google.rb 0.0 %

@abinashpa
Copy link
Contributor Author

Loom

Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, few small changes 🙂

app/models/timesheet_entry.rb Show resolved Hide resolved
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 February 21, 2022 04:21 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 February 21, 2022 08:21 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 March 7, 2022 09:29 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 March 7, 2022 09:30 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 March 7, 2022 09:44 Inactive
@abinashpa abinashpa removed the request for review from shivamsinghchahar March 7, 2022 09:52
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 March 7, 2022 10:07 Inactive
Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few non blocking comments.

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some concerns

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-158 March 8, 2022 06:03 Inactive
@akhilgkrishnan akhilgkrishnan merged commit 0df0ecf into develop Mar 8, 2022
@akhilgkrishnan akhilgkrishnan deleted the refator-day-timetracking branch March 8, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants