-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added active_for_authentication method in the user.rb #141
Merged
akhilgkrishnan
merged 1 commit into
develop
from
140-discarded-user-should-not-be-able-to-login
Feb 9, 2022
Merged
Added active_for_authentication method in the user.rb #141
akhilgkrishnan
merged 1 commit into
develop
from
140-discarded-user-should-not-be-able-to-login
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketkaushik
requested review from
keshavbiswa,
rohitjoshixyz and
akhilgkrishnan
February 9, 2022 14:04
Current Code Coverage Percent of this PR:68.57 %Files having coverage below 100%
|
akhilgkrishnan
changed the title
Fixes #140 added active_for_authentication method in the user.rb
Added active_for_authentication method in the user.rb
Feb 9, 2022
rohitjoshixyz
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
aniketkaushik
force-pushed
the
140-discarded-user-should-not-be-able-to-login
branch
from
February 9, 2022 14:18
e89a93e
to
0eaf587
Compare
akhilgkrishnan
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 , Please resolve the conflic
akhilgkrishnan
deleted the
140-discarded-user-should-not-be-able-to-login
branch
February 9, 2022 14:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
https://www.loom.com/share/3a2af561c104485dbf3c7fe3fd3b143b
Description
added code, only non discarded user will be able to Sign In.
Fixes #140
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: