Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added active_for_authentication method in the user.rb #141

Merged

Conversation

aniketkaushik
Copy link
Contributor

@aniketkaushik aniketkaushik commented Feb 9, 2022

Pull Request Template

https://www.loom.com/share/3a2af561c104485dbf3c7fe3fd3b143b

Description

added code, only non discarded user will be able to Sign In.

Fixes #140

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-141 February 9, 2022 14:04 Inactive
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Current Code Coverage Percent of this PR:

68.57 %

Files having coverage below 100%

Impacted Files Coverage
/config/routes.rb 94.74 %
/app/models/user.rb 82.35 %
/app/controllers/projects_controller.rb 50.0 %
/app/controllers/application_controller.rb 77.78 %
/app/helpers/application_helper.rb 80.0 %
/app/helpers/team_helper.rb 57.14 %
/app/controllers/time_tracking_controller.rb 30.0 %
/app/controllers/concerns/timesheet.rb 37.5 %
/app/controllers/company_controller.rb 67.65 %
/app/controllers/root_controller.rb 33.33 %
/app/controllers/team_controller.rb 38.46 %
/app/controllers/dashboard_controller.rb 66.67 %
/app/controllers/clients_controller.rb 66.67 %
/app/controllers/concerns/error_handler.rb 60.0 %
/app/models/timesheet_entry.rb 81.25 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 45.83 %
/app/controllers/users/invitations_controller.rb 63.64 %
/app/controllers/internal_api/v1/application_controller.rb 85.71 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 35.71 %

@akhilgkrishnan akhilgkrishnan changed the title Fixes #140 added active_for_authentication method in the user.rb Added active_for_authentication method in the user.rb Feb 9, 2022
@aniketkaushik aniketkaushik self-assigned this Feb 9, 2022
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@aniketkaushik aniketkaushik force-pushed the 140-discarded-user-should-not-be-able-to-login branch from e89a93e to 0eaf587 Compare February 9, 2022 14:18
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 , Please resolve the conflic

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-141 February 9, 2022 14:18 Inactive
@akhilgkrishnan akhilgkrishnan merged commit b496e25 into develop Feb 9, 2022
@akhilgkrishnan akhilgkrishnan deleted the 140-discarded-user-should-not-be-able-to-login branch February 9, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only Non Discard User should be able to LogIn
4 participants